Conversation
fmoc
changed the title
|
@SamuAlfageme who can help here? |
|
@fmoc @michaelstingl thanks for taking the time to review the status of your fork! I'll go through it and merge it 🚀 (It's no longer a draft PR, right?)
Thank you for the tip too, did you run the content of the repo against it? Maybe I can introduce it as some CI for this repo. |
Feel free to remove the draft status. It's a draft because I wanted to make sure you have a look at the proposed changes. As said, I'm not really into this repository, I can't really tell whether all ported changes make sense. I really hope they do, though.
No, I have not. I would have had to make a huge reformat commit first, but that'd ruin the Git history to some extent. Not everyone's a fan of that. IMO, you need to establish such formatters from the beginning, or only ever apply it to changes when you introduce it later. |
3 participants
Closes #135.
I am not really familiar with this project, but I took the time to carefully reviewed all differences and reduced the changeset to a minimum.
Please feel free to review the PR and tell us whether some of the changes can be excluded, I'll happily update the PR.
By the way, you may want to look into black. I can highly recommend this auto formatter.